Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: mod compilation error message #2432

Conversation

andrew-raphael-lukasik
Copy link
Contributor

@andrew-raphael-lukasik andrew-raphael-lukasik commented Sep 19, 2022

What

A change in DaggerfallWorkshop.Game.Utility.Compiler to help fellow mod developers fix mod compilation errors more easily.

edit: since 1911297 this includes minimal changes in Mod.cs and ModManager.cs so compilation API can pass mod title+version as an optional parameter.

Why

I compiled a mod, ran the game, mod failed to load. Saw this error message:
Screenshot 2022-09-19 160736 b

Results

Now I can see this:

Screenshot 2022-09-20 162939

@andrew-raphael-lukasik andrew-raphael-lukasik changed the title fix: slightly better mod compilation message improvement: slightly better mod compilation message Sep 19, 2022
@andrew-raphael-lukasik andrew-raphael-lukasik marked this pull request as draft September 20, 2022 08:27
@andrew-raphael-lukasik andrew-raphael-lukasik changed the title improvement: slightly better mod compilation message improvement: mod compilation error message Sep 20, 2022
@andrew-raphael-lukasik
Copy link
Contributor Author

andrew-raphael-lukasik commented Sep 20, 2022

There is still a type of error message that I am not sure how to improve (data is missing or misinterpreted). It looks like this:

[NPCHealthIndicators 1.1.1] Error : Index was outside the bounds of the array.
at line#0 column#0

But merely being able to see a mod name attached is a useful hint already. I think modders will appreciate this change as I can see popular mods reporting errors and those probably weren't getting fixed precisely because of lack of meaningful cues.

@andrew-raphael-lukasik andrew-raphael-lukasik marked this pull request as ready for review September 20, 2022 17:52
@Interkarma
Copy link
Owner

Nice work adding some more details to these errors. I have no doubts mod developers will appreciate the change. :)

@Interkarma Interkarma merged commit 946a03a into Interkarma:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants