Embed AudioSynthesis code and remove DLL #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally "C# Synth Project" at site: http://csharpsynthproject.codeplex.com/ This is now gone, so wayback: https://web.archive.org/web/20151110123619/http://csharpsynthproject.codeplex.com/ I think some changes from below topic were used when adapting to Unity. https://forum.unity.com/threads/unitysynth-full-xplatform-midi-synth.130104/ Hard to recall exactly as AudioSynthesis.dll was last updated in 2015. I made some changes also. I no longer had the code for this on hand. I eventually located project on one of my old HDDs. Took some effort to find. Having this in code will allow fixing issue in Turkish language found by TheLacus and reported in below forum reply. Affecting code is in SoundFont.cs. https://forums.dfworkshop.net/viewtopic.php?p=52754#p52754 Removed AudioSynthesis DLL and music still plays OK. It's the same plugin, just not in DLL form. Still need to apply TheLacus' suggested fix for Turkish and test everything. Putting it all in a branch for now. It's all self-contained so can be merged at any time when ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally "C# Synth Project" at site: http://csharpsynthproject.codeplex.com/ This is now gone, so wayback: https://web.archive.org/web/20151110123619/http://csharpsynthproject.codeplex.com/ I think some changes from below topic were used when adapting to Unity. https://forum.unity.com/threads/unitysynth-full-xplatform-midi-synth.130104/ Hard to recall exactly as AudioSynthesis.dll was last updated in 2015. I made some changes also. I no longer had the code for this on hand. I eventually located project on one of my old HDDs. Took some effort to find. Having this in code will allow fixing issue in Turkish language found by TheLacus and reported in below forum reply. Affecting code is in SoundFont.cs. https://forums.dfworkshop.net/viewtopic.php?p=52754#p52754 Removed AudioSynthesis DLL and music still plays OK. It's the same plugin, just not in DLL form. Still need to apply TheLacus' suggested fix for Turkish and test everything. Putting it all in a branch for now. It's all self-contained so can be merged at any time when ready.