-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uname() for getparm for ARCH/MACH queries. #129
base: master
Are you sure you want to change the base?
Use uname() for getparm for ARCH/MACH queries. #129
Conversation
It's not clear to me why returning the OS name (sysname) for ARCH is a good choice. The existing code was, I suspect, attempting to duplicate the result of the SunOS/Solaris "arch" and "mach" commands and simulate it where it didn't exist. I wouldn't object to OSNAME as another parameter it returns, though, because it makes it easler for Lisp code to adapt to the underlying system.
FreeBSD says
Solaris 11.4 says:
|
what is most useful going forward? Labels to put on benchmarks? deciding what to send to ShellCommand?
|
How is this actually used from within Medley? The comment indicates that it isn’t used much except for whether or not |
It's not a closed universe -- we have no idea how it might have been used. |
The good thing about a 30 year gap in history is that all of the platforms that were supported, except Solaris and sort-of-DOS, are dead now. So any legacy code checking this for things like MIPS or 68k or Irix or AIX ... wouldn't care what the new values are. So I think it is best if we can get it right now. It is also worth noting that many of our current platforms are mis-reported by this, like any ARM / Aarch64 platforms. |
Previously, this was implemented in very inconsistent ways and not yet implemented for most of the platforms that we're supporting today. The values for DOS are maintained as they were.
a2ca722
to
0fbef6e
Compare
getting something that is meaningful for labelling benchmarks would be good. |
doesn't this provide Ron with what he needs for clipboard? |
No, it doesn't tell you which OS you're running -- could be x86_64 darwin, or x86_64 linux, and they need different copy/paste commands. It also tells you "X", but they're all "X', so that's no help. I think we can probably settle on something for "MACH" and "ARCH", but Ron needs "OSNAME" -- and we'll get that from the OS we compiled on. I've got a lot of things I'm working on. |
Ron should be using new subrs that let Maiko correctly implement copy/paste. Doing otherwise simply won't work on all platforms going forward as shell commands aren't always available to do this. |
Previously, this was implemented in very inconsistent ways and
not yet implemented for most of the platforms that we're supporting
today.
The values for DOS are maintained as they were.