CHAT library needs update (see summary)

[masinter]

prints in terminal window "Open lisp side of PTY failed."
(This isn't new behavior, just reporting it now)

[nbriggs]

OS and processor architecture?

[masinter]

I tried it on a mac darwin.x86_64 and on WSL linux.x86_64 with same result.
A different result in full.venuesysout -- \ILLEGAL.ARG error.

[nbriggs]

Works ok for me in a full.venuesysout, with lde built at commit d717946929b3eda5b1a05fb1d491dd404d88f9ec (current head of master).

Make sure that the ldex that lde is finding is the current one -- if you're running from a directory that isn't on your search path the lde may find an old one that is on your search path.

[masinter]

i did a pull and makeright starting with full.venuesysout on three different systems (WSL linux, MacOS high sierra, raspbian)
the problem is in FORK-SHELL

prints "Open of lisp side of PTY failed." and fails. Some environment variable you set and I don't?

[masinter]

I tried compiling unixcomm.c with -DDEBUG and got this output

Entering FindUnixPipes
NPROCS is 1024; leaving FindUnixPipes

Unix_handlecomm: trying 8

Unix_handlecomm: trying 11
Trying /dev/ptyp0. Trying /dev/ptyp1. Trying /dev/ptyp2. Trying /dev/ptyp3. Trying /dev/ptyp4. Trying /dev/ptyp5. Trying /dev/ptyp6. Trying /dev/ptyp7. Trying /dev/ptyp8. Trying /dev/ptyp9. Trying /dev/ptypa. Trying /dev/ptypb. Trying /dev/ptypc. Trying /dev/ptypd. Trying /dev/ptype. Trying /dev/ptypf. Trying /dev/ptyq0. Trying /dev/ptyq1. Trying /dev/ptyq2. Trying /dev/ptyq3. Trying /dev/ptyq4. Trying /dev/ptyq5. Trying /dev/ptyq6. Trying /dev/ptyq7. Trying /dev/ptyq8. Trying /dev/ptyq9. Trying /dev/ptyqa. Trying /dev/ptyqb. Trying /dev/ptyqc. Trying /dev/ptyqd. Trying /dev/ptyqe. Trying /dev/ptyqf. Trying /dev/ptyr0. Trying /dev/ptyr1. Trying /dev/ptyr2. Trying /dev/ptyr3. Trying /dev/ptyr4. Trying /dev/ptyr5. Trying /dev/ptyr6. Trying /dev/ptyr7. Trying /dev/ptyr8. Trying /dev/ptyr9. Trying /dev/ptyra. Trying /dev/ptyrb. Trying /dev/ptyrc. Trying /dev/ptyrd. Trying /dev/ptyre. Trying /dev/ptyrf. Fork Shell; Master PTY = -1. Slave=rf.
Open of lisp side of PTY failed.

[nbriggs]

It looks to be because there are now different ptyxx names. On my mac it's /dev/pty[pqr][0-9a-f], on the Linux (Ubuntu on x86_64 and Debian 10 on ARMv7) I'm looking at it's /dev/tty%d for d from 0..63.

The code in unixcomm.c says:

  /*      Assumes that valid PTY names are [pqr][0-f]; if your system     */
  /*      is different, you'll need to change it.                         */

So I supposed we need to make it either probe a little smarter or add #ifdef (ostype) to it

[waywardmonkeys]

Probably need to move to the POSIX API instead of BSD pseudoterminals.

That means moving to posix_openpt and friends. It seems like there is appropriate platform support for the POSIX API. Shouldn't be too bad! Hopefully ...

[waywardmonkeys]

There's a bit of historical background in https://man7.org/linux/man-pages/man7/pty.7.html

[waywardmonkeys]

I'll take a bit of a look at this and toss up a PR in the next few hours.

[masinter]

What's odd is that ShellCommand("pwd") succeeds (as do others) but the debug output is extensive:

Entering FindUnixPipes
NPROCS is 1024; leaving FindUnixPipes

Unix_handlecomm: trying 8

Unix_handlecomm: trying 0
Socket 6 bound to name /tmp/LPU15731008-6.
Sending cmd string: pwd

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status -1 from read, errno 11.

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2

Unix_handlecomm: trying 9
Read buffer slot 7, type is -2
Problem: Got status 0 from read, errno 11.
find_process_slot = 7.
Process 2213 exited status 0
read failed; dest = 0, errno = 4, status = 0
Indicating EOF from PTY desc 7.

Unix_handlecomm: trying 3
Killing process in slot 7.
Kill 3 closing process desc 7.

[nbriggs]

Executing commands is done differently from chat(shell).