Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git commit ID to beginning of loadups .dribble files. #1778

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MattHeffron
Copy link
Contributor

The commit ID is put into the .dribble file in the .sh scripts. (using echo ... > name.dribble)
The changes to the lisp files MEDLEY-UTILS, LOADUP-FULL, and LOADUP-LISP are to enable DRIBBLE in append mode; i.e., the passing of APPENDFLG to (DRIBBLE ... APPENDFLG).

The commit ID is put into the .dribble file in the .sh scripts. (using echo ... > name.dribble)
The changes to MEDLEY-UTILS, LOADUP-FULL, and LOADUP-LISP are to enable the passing of APPENDFLG to (DRIBBLE ... APPENDFLG).
@MattHeffron MattHeffron added the enhancement New feature or request label Jul 3, 2024
Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell what problem these changes are solving.
The original problem, I thought, was that it was difficult to tell, from inside OR otuside the sysout (or preferably both) what system you were running in, ffor the purposes of aiding someone reading or writing an issue.

I see it's adding some info in the dribble files, and saving the dribble files was intended to somehow aid in this task, but it turns out they don't and adding more information to them don't help to close the connection. The filedates of each file loaded in the sysout are actually in the sysout already. We're missing the commit IDs of the files actually loaded.

The changes look innocuous but my (earlier) PR also changes MEDLEY-UTILS although the merge of the two sets of changes isn't something you cah do easily, unfortunately, with current GITFNS.

@MattHeffron MattHeffron marked this pull request as draft July 4, 2024 18:42
@MattHeffron
Copy link
Contributor Author

Withdrawing these changes.
I will leave the branch to keep the implementation of acquisition of the git commit ID in the scripts.
Once it is defined where and how that is to be retained within the sysout, then that can be implemented instead.

@MattHeffron MattHeffron closed this Jul 4, 2024
@masinter
Copy link
Member

masinter commented Jul 8, 2024

Putting more info in the dribble file is useful and certainly harmless, i just thought we likely need more. I look around and I have a lot of sysouts and there's no way now to tell exactly what they are, even when I run them.

This is more a modern problem that wasn't much of an issue back then because sysouts were relatively huge.

@MattHeffron MattHeffron marked this pull request as ready for review August 27, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants