Fix error in lsee RegEx to replace ^ with ↑ #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a cheap hatch that should convert MCCS to utf8. But that would be .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RegEx in lsee to replace
^with↑didn't quote (backslash) the^so it was interpreted as the start of line pattern.Fixes Discussion #2137
I noticed that this will not convert
\r\nto\n, but only changes the\rto\nwhich, for a files withcr-lfend-of-line, would result in double line spacing. This case shouldn't happen, but could (especially on Windows) by an improperly setup git, or editing a file in a Windows text editor.