Skip to content

Update lispusers module INSPECTCODE-TEDIT for changes to Tedit. #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 30, 2025

Conversation

MattHeffron
Copy link
Contributor

Update lispusers/INSPECTCODE-TEDIT for changes to Tedit.
This could be considered to be incorporated directly into sources/INSPECT.
(This was changed from TCOMPL (LCOM) to COMPILE-FILE (DFASL) because it just wouldn't compile correctly otherwise, for me.)

Branch rmk106 is a prerequisite to this.

rmkaplan and others added 4 commits July 21, 2025 12:45
This could be considered to be incorporated directly into sources/INSPECT.
(This was changed from TCOMPL (LCOM) to COMPILE-FILE (DFASL) because it just wouldn't compile correctly otherwise, for me.)
@MattHeffron MattHeffron self-assigned this Jul 24, 2025
@MattHeffron MattHeffron requested a review from rmkaplan July 24, 2025 02:20
@rmkaplan
Copy link
Contributor

I built a loadup and then tried (FILESLOAD INSPECTCODE-TEDIT). It failed in the load, apparently when it was trying to do some advising.
Screenshot 2025-07-28 at 12 15 17 PM

@MattHeffron
Copy link
Contributor Author

MattHeffron commented Jul 29, 2025

It failed in the load, apparently when it was trying to do some advising.

It requires exports.all loaded in order to be compiled.
My initial commit (c9d100f) was broken in the advice. (I thought that I had tested it in a fresh loadup...)

I'm still unsure why TCOMPL wouldn't compile it. Complained about mismatch file maps.

@pamoroso
Copy link
Contributor

How can I test this change? I seem to understand I have to check out both rmk106 and mth46 but how can I keep a working tree that includes both?

@MattHeffron
Copy link
Contributor Author

How can I test this change?

@pamoroso You should be able just to check out mth46. It has the rmk106 merged in already.

The note about rmk106 as a prerequisite is just to remind that this PR shouldn't be merged until rmk106 has been merged, because merging mth46 will bring the rmk106 changes as well.

Copy link
Contributor

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change on Linux Mint 22.1 Cinnamon and the reported issues, such as the screen flashes when opening the grapher, are fixed.

Copy link
Contributor

@rmkaplan rmkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out, now works

@rmkaplan rmkaplan merged commit 4019578 into master Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants