Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Analytics to Online Interlisp. #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

stumbo
Copy link
Member

@stumbo stumbo commented Jun 16, 2023

I've never used PUG before - so, please make sure I got this right. The two scripts should be in the header and in something that is present on every page.

@stumbo stumbo requested a review from fghalasz June 16, 2023 03:15
@fghalasz
Copy link
Member

fghalasz commented Jun 16, 2023

This looks good to me. I will build a dev version and put it online (at online.interlisp.org:8081) and we can try it out.

You might also want to tag the noVnc page in which Interlisp actually 'runs'. In git its stored at web-portal/client/novnc-oio/vnc.html. Its a very complicated hmtl page that comes from the noVnc distribution and has a few simple mods for interlisp online.

@fghalasz
Copy link
Member

@stumbo Your pages with the google tags are now up and running on the dev portal (online.interlisp.org:8088). I visited a few pages - so you should see some activity via google analytics.

Let me know if its working.

@stumbo
Copy link
Member Author

stumbo commented Jun 17, 2023

It works!
image

I also found a link back to the Interlisp web site that was broken on my side.

I'll update the PR with the changes for web-portal/client/novnc-oio/vnc.html

@fghalasz
Copy link
Member

@stumbo dev portal (online.interlisp.org:8081) has been updated with latest (i.e., with tag code in vnc.html). I visited vnc.html a couple of times. Should show up in analytics now.

@stumbo
Copy link
Member Author

stumbo commented Jun 18, 2023

Updates appear to be working correctly. I see the noVNC is being called:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants