Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ascend kernels #2355

Merged
merged 17 commits into from
Aug 30, 2024
Merged

Conversation

yao-fengchen
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support 910b using dlinfer instead of deeplink_ext.

Modification

Refactor ascend kernerls and ASCENDDeviceUtils.
Remove dipu kernels and DIPUDeviceUtils.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@yao-fengchen yao-fengchen marked this pull request as draft August 22, 2024 09:04
@yao-fengchen yao-fengchen force-pushed the refactor-ascend-kernels branch from 5007074 to ef4d9c8 Compare August 23, 2024 08:46
@yao-fengchen yao-fengchen force-pushed the refactor-ascend-kernels branch from ef4d9c8 to 41e1398 Compare August 23, 2024 09:22
@yao-fengchen yao-fengchen marked this pull request as ready for review August 28, 2024 05:17
@lvhan028 lvhan028 merged commit 32c8580 into InternLM:main Aug 30, 2024
4 of 5 checks passed
@yao-fengchen yao-fengchen deleted the refactor-ascend-kernels branch September 5, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants