Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated stuff #13

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix deprecated stuff #13

wants to merge 2 commits into from

Conversation

apple502j
Copy link
Member

No description provided.

@jacob-g jacob-g added the prio-low Low Priority label Oct 17, 2022
@jacob-g
Copy link
Member

jacob-g commented Oct 17, 2022

We don't have any immediate plans to host an election, so I am going to mark this as low priority. In the unlikely event we can't get this handled before the upgrade, we will just disable the extension until we can handle this.

jacob-g
jacob-g reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@jacob-g jacob-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good from reading it. Will test on 1.35 and 1.39 when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-g jacob-g jacob-g left review comments

@Kenny2github Kenny2github Awaiting requested review from Kenny2github

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
prio-low Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apple502j @jacob-g