Issue ID Card credential #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsan-fj
reviewed
Apr 13, 2021
| @@ -93,19 +93,21 @@ | |||
| luxon.Settings.defaultLocale = LOCALE_NZ; | |||
|
|
|||
| const now = luxon.DateTime.now().toUTC(); | |||
| const expiryDate = luxon.DateTime.now().plus({years: 10}).toUTC(); | |||
| const validity = now.plus({months: 1}).toUTC(); | |||
There was a problem hiding this comment.
Can I ask why 1 month validity?
There was a problem hiding this comment.
Yes worth a discussion. I mentioned 1 month as an idea for a business model might be a monthly subscription to have access to the digital version of the physical card. It's really just a chance for us to play with and test this particular feature of IRMA we haven't used yet.
There was a problem hiding this comment.
Currently the agreed Acceptance Criteria for https://app.asana.com/0/1171124854073033/1200078086990964. But we can discuss and change it quite easily as Cam explained.
ehsan-fj
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1171124854073033/1200170072663607