Merge pull request #62 from InternetNZ/develop

supporting historic domains by making contacts optional (#61)
InternetNZ · Oct 9, 2023 · d9d5765 · d9d5765
2 parents 7723917 + 546a638
commit d9d5765
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/pyepp/__init__.py b/pyepp/__init__.py
@@ -1,6 +1,6 @@
 """
 PyEPP Package
 """
-__version__ = "0.0.5"
+__version__ = "0.0.6"
 
 from pyepp.epp import EppCommunicator, EppResultCode, EppCommunicatorException
diff --git a/pyepp/domain.py b/pyepp/domain.py
@@ -70,10 +70,10 @@ class DomainData:
     """Domain name dataclass."""
     # pylint: disable=too-many-instance-attributes
     domain_name: str
-    registrant: str
-    admin: str
-    tech: str
-    period: int
+    period: Optional[int] = None
+    registrant: Optional[str] = ''
+    admin: Optional[str] = ''
+    tech: Optional[str] = ''
     sponsoring_client_id: Optional[str] = ''
     billing: Optional[str] = ''
     status: Optional[list[str]] = None
@@ -202,7 +202,7 @@ def create(self, domain: DomainData, client_transaction_id: Optional[str] = None
         """A successful Domain Create request creates a domain object in the Registry, and also creates relationships
         between the domain name and previously created contacts and hosts.
 
-        :param domain: Contact
+        :param domain: Domain name details
         :param client_transaction_id: Client transaction id
 
         :return: Result object