White labeling test #100
Closed
White labeling test #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that users only have to go to one place (other than colorPalette) to modify the look. Will revert this if it doesn't survive testing.
Testing the toolbar next
Reason: The original pull request had these UI elements set for a 30px toolbar. Had to nudge them back down for a 40px toolbar. Will re-adjust this on the UI sweep of this project.
this was causing errors on installs
Reason: Font tweaks led to issues with the right-border affixed to the workspace menu opener. I placed in seperators to fix this. Out of scope for this PR, but had to be done in order to not leave fsbl worse off than it was before.
* Make fake tabs, make them rectangular. * 7060 make space on right for dragging tabbed windows * Move tabRegion out into its own folder. move tabs into the center folder. * Put drag region into the tab area. Accept drops. Calculate dragLeave, etc. * Made ghostTab the proper color. Cleaned up some styling. * Figured out dragOver * Allow more than 2 tabs * Fix some z-index collisions. * Implement tab scrolling * Move events up to the parent * Fixed overflow on titles. * Reduce font-weight of roboto. Fix some idiosyncracies of the drag action. Style ghost-tab better. Don't show ghost-tab on the originating window. * Added hover-effect to let users know that they can drag the title of a window. * use window event instead of FSBL Ready in prep for some header optimization * Did some refactoring of scroll code to make it clearer. * Only render left section if there's something in there. This gets rid of teh right border. * Fix issue where margin-left was pushing the dropzone off of the screen. O_O * So much documentation * Fixed error * Cleanup * More cleanup and documentation * Should've been about 40 commits. Moved most of the logic out of the components and into the store. Added drag and drop reordering. * Remove unnecessary docs * Add gradient to the drag-areagit statusgit status! * In the middle of working on integration * Merge and fix gradient * Fix mouseWheel * Fixes to integrate with the tabbing API * Responsive header * 7021 responsive * Responsive tab sizesgit pushgit push * Fix UI * Fix dropping interaction with tiling * handle clearParent event in titleBar * Make window look to the stack's group state instead of its own. * YOu can reload and your tabs won't go awaygit status! * Close window now * Dropping out of a tab and tile thing works * Think i solved dragging issues * added tabbing action to stoptilingortabbing * Stop propogation on the tab close, so it doesn't set the tab active _after_ the tab was closed. * store changes * Code for closing a stack * Fix state issue with no tabs * Fix weird tab size when dragging * Clear tabs on clearParent * Initial header color * Icon color is blue * Made the active tab always the window that the tab list is in. This reduces flicker on visible window change. * Instrumentation, wait for remove before continuing, check groups when parentSet is called * Sped up initial group creation a little * Can remove a tab and then tab it againgit status * Get rid of 15px space for tabs. * Fixed window resizing. Adjusted tab colors. * Add terry-class * HoverDetector on tabs * HoverDetector on fsbl-header-title * Allow drag on cancel. * Fixed right border logic on tab-region-wrapper * Make sure there's always some room to grab header on single windows. * Remove local tab on cancel. fixed scrolling. * Move logs to log. * TYPO * Another log * TYPO * add action detaching * more instrumentation * Icon is blue, tab titles left-aligned. * fix for drop on scrim * Added fsbl-drag-region * Removed the flaky placeholder that would move to and fro. * Made tab updates look a little nicer. * Fix reordering two tabs. * fix tiling * Added ellipses on overflow for single tab * Don't do anything if we drop a tab onto ourselves. * remove tooltips * Remove log in the render function * Drop log level of some tab methods. * Make window title appear when tabs are disabled * Further changes to fix window titleBar when no tabs * Change assimilation version * Handle error in getStackedWindow * made right drag area responsive. * RESPONSIVE TABSgit status! * Allow reorder of active tab * Fix drop on self
added 10 commits
June 12, 2018 10:23
added 13 commits
June 13, 2018 10:12
There was a bug that was preventing drag-to-share from appearing.
Still need to figure out why styles are not being overriden
This is a hackfix until we can figure out why notifications are resistant to style overwrites.
and deleted instances of _variableWhiteLabel.css
MattSwartz
pushed a commit
that referenced
this pull request
Sep 3, 2020
* Allow core to be built on latest node version - Use `>12` instead of `^12` * Add quotes to copyfiles in package.json - On MacOS the quotes are necessary - Result is that ttf and img files don't get moved to /react dist folder - import error on "./fonts/font-finance.ttf" * Proper quoting of package.json commands - Turns out that single quotes work on Mac but not Windows - \" is the cross-platform way to quote - Use \\\" to include a quote within a quoted argument! (none in here but FYI) - Ultimately this is super-fragile. This build code should be moved downward into localized node code (gulp, node or cli) * Updated yarn.lock from dependency changes * Added comments to readme for future build strategy - placeholder, project was deadended because of timelines * Blank index.d.ts files to work around tsc idiosyncracy - microsoft/TypeScript#27956 - Was throwing tsc errors that caused build to break in production mode * Refactor of core build process - Simplified package.json - DRY webpack configs - Cleaned up readme * Dummy index.d.ts files in package.json - For tsc idiosyncracy * Added standalone "launch" to seed - Launches finsemble without build or server * Removed duplicate function call - Caused webpack to break in production mode * Added error output to seed webpack - Needed to read "stats" object for errors - Commented out warnings because we have too many to resolve right now * Added top level prod build to monorepo - `yarn prod` to run in production - Non-parallelized build. Total refactor needed to do otherwise. * Eliminated packaged finsemble.css in favor of files - Bug in mini-css-export-plugin was maddening - Decided to caveman the problem and just copy files from node_modules into assets - In the end, this is more web and less webpack, so better and faster - Work being done in CopyWebpackPlugin but ought to be refactored because it's not really a webpack task at all. * Remove "finsemble" and "installer-tmp" on clean - installer-tmp can get left hanging around - finsemble will get copied again with next build * Caching for production mode is now zero - This was tripping us up over and over in development - If you ran production mode just once, then no code changes would take effect for 24 hours - Instead, we added some guidance on setting up production mode as comments within the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs linked to Finsemble - master
Placed in old white label and tweaked to fit the new paradigm. Should appear nearly identical to previous.