Skip to content

Commit

Permalink
Merge #4048 #4137
Browse files Browse the repository at this point in the history
4048: Expose Key interface in Cardano.Api.Shelley r=ch1bo a=ch1bo

Sorry for this unsolicited PR, it is *not* crucial for us, but we wanted to get also your feedback on:

In the Hydra project we are using the cardano-api quite heavily and thought we could distinguish Hydra key types using the same framework, but just with a new `Hydra` key role. 

Unfortunately it was not possible because some of the type class definition was not exported.

This PR exposes the full type class to be able to define instances of it and having a `Hydra` key role, this yields `SigningKey Hydra` and `VerificationKey Hydra` key types.

See also this PR: cardano-scaling/hydra#398

4137: Give myself and John permission to merge any PR r=Jimbo4350 a=Jimbo4350



Co-authored-by: Sebastian Nagel <sebastian.nagel@ncoding.at>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
  • Loading branch information
3 people authored Jul 5, 2022
3 parents 4e076d3 + 3122b3b + e8c795f commit 7725ccd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/Cardano/CLI/Byron/Run.hs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import qualified Cardano.Crypto.Hashing as Crypto
import qualified Cardano.Crypto.Signing as Crypto

import Cardano.Api hiding (UpdateProposal, GenesisParameters)
import Cardano.Api.Byron (SomeByronSigningKey (..), Tx (..), VerificationKey (..))
import Cardano.Api.Byron (SomeByronSigningKey (..), Tx (..))

import Ouroboros.Consensus.Byron.Ledger (ByronBlock)
import Ouroboros.Consensus.Ledger.SupportsMempool (ApplyTxErr)
Expand Down
1 change: 0 additions & 1 deletion src/Cardano/CLI/Shelley/Run/Key.hs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import qualified Cardano.Crypto.Wallet as Crypto
import qualified Cardano.Ledger.Keys as Shelley

import Cardano.Api
import Cardano.Api.Byron hiding (SomeByronSigningKey (..))
import qualified Cardano.Api.Byron as ByronApi
import Cardano.Api.Crypto.Ed25519Bip32 (xPrvFromBytes)
import Cardano.Api.Shelley
Expand Down

0 comments on commit 7725ccd

Please sign in to comment.