Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize ouroboros-consensus's PoolDistr instead of cardano-ledger's PoolDist #562

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jun 20, 2024

Changelog

- description: |
    Deserialize `ouroboros-consensus`'s `PoolDistr` instead of `cardano-ledger`'s `PoolDist` to maintain backwards compatibility with the `PoolDistr` query. This is needed because `cardano-ledger`'s `PoolDistr` datatype has changed.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

version of `PoolDistr` so that `decodePoolDistribution` would use the correct cbor instances
Ledger has updated it's definition of `PoolDistr` however to avoid
breakage consensus implemented a backwards compatible version of
`PoolDistr`
@Jimbo4350 Jimbo4350 enabled auto-merge June 20, 2024 12:24
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Jun 20, 2024
@Jimbo4350 Jimbo4350 removed this pull request from the merge queue due to a manual request Jun 20, 2024
@Jimbo4350 Jimbo4350 merged commit b0e5209 into main Jun 20, 2024
24 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/pooldistr-serialization-fix branch June 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants