Update substituteExecutionUnits to include proposal and vote script witnesses #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
Jimbo4350
changed the title
Jimbo4350
force-pushed
the
jordan/map-voting-and-proposing-script-witnesses
branch
2 times, most recently
from
01e1fd6
to
00c9865
Compare
smelc
approved these changes
Jul 17, 2024
carbolymer
approved these changes
Jul 17, 2024
| Right . TxMintValue supported value . BuildTxWith $ | ||
| Map.fromList final | ||
|
|
||
| traverseScriptWitnesses | ||
| :: [(a, Either (TxBodyErrorAutoBalance era) (ScriptWitness ctx era))] | ||
| -> Either (TxBodyErrorAutoBalance era) [(a, ScriptWitness ctx era)] |
There was a problem hiding this comment.
Wouldn't it be useful to aggregate errors here?
There was a problem hiding this comment.
Yes it would be; could do so in a follow up PR.
Jimbo4350
force-pushed
the
jordan/map-voting-and-proposing-script-witnesses
branch
from
00c9865
to
cc238ec
Compare
…ness index in the execution units map Remove mapTxScriptWitnessses Update substituteExecutionUnits to update proposal and vote script witnesses
miss updating the execution unit substitution for new plutus script purposes
Jimbo4350
force-pushed
the
jordan/map-voting-and-proposing-script-witnesses
branch
from
cc238ec
to
99ff62f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist