Add support for mempack
#506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/use-mempack
branch
2 times, most recently
from
0f1cec6
to
e73f1ab
Compare
lehins
force-pushed
the
lehins/use-mempack
branch
from
e73f1ab
to
a6a9bf7
Compare
During deserialization we create a temporary buffer, whcih is later converted to `PackedBytes` representation. There is no need fort hat intermediarey buffer to be backed by pinned memory (i.e. `ByteString`) This commit switches to using unpinned `ShortByteString` in order to reduce fragmentation of pinned memory due to deserialization of milllions of hashes on a running node
lehins
force-pushed
the
lehins/use-mempack
branch
from
7516c6d
to
1c34921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for serializing/deserializing
Hashes usingmempacklibrary. This is needed for Ledger to implement efficient snapshot creation.The only breaking affect on downstream users of this PR is that
Hashserialization will now requireKnownNatorHashAlgorithmconstraint.Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)