Support ghc-9.12 #510
Support ghc-9.12 #510
Conversation
| -- | ||
| -- -- Copied from the "NoThunks.Class" | ||
| -- class GShowTypeOf f where gShowTypeOf :: f x -> String | ||
| -- instance Datatype c => GShowTypeOf (D1 c f) where gShowTypeOf = datatypeName |
There was a problem hiding this comment.
Not sure about this. GWNoThunks seems to have been removed from the nothunks library.
There was a problem hiding this comment.
Have asked @nfrisby in Slack about this.
| if impl(ghc >= 9.12) | ||
| ghc-options: -Wno-deriving-typeable |
There was a problem hiding this comment.
It is better to remove all places where Typeable is being derived, instead of turning off the warning
There was a problem hiding this comment.
I am assuming that all places that Typeable is derived, it is needed for compilers < 9.12.
Assuming that's the case, there are two options:
- DIsabling the warning for
ghc >- 9.12 - Use CPP to hide the derivation of
Typeablewhneghc >= 9.12
I thought the former was the least invasive solution.
There was a problem hiding this comment.
I am assuming that all places that Typeable is derived
FYI. All types by default in haskell starting with ghc-7.10 have Typeable, so it does not need to be derived anymore. That is exactly what the warning is about.
So, please do not disable warnings, they are actually trying to tell you something.
All you need to do is remove deriving Typeable. That's all.
There was a problem hiding this comment.
Here is some documentation that you can read about it: https://hackage.haskell.org/package/base-4.20.0.1/docs/Data-Typeable.html#description
erikd
force-pushed
the
erikd/ghc-9.12
branch
4 times, most recently
from
8abcd5a to
36fd7e6
Compare
erikd
force-pushed
the
erikd/ghc-9.12
branch
from
36fd7e6 to
f293705
Compare
erikd
force-pushed
the
erikd/ghc-9.12
branch
3 times, most recently
from
77ee665 to
a4c941c
Compare
Description
Should not be merged until SRP and most
allow-newers are removed.Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)