Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test of create-cardano #907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Sep 20, 2024

Changelog

- description: |
    Add a test of create-cardano
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Since I'm going to share some code between create-cardano and create-testnet-data (for #765), I thought this was a good occasion to at least call create-cardano once in our tests. It's bad to provide a command and not test it at all.

How to trust this PR

The new test passes

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's already genesis in cardano-cli/test/cardano-cli-test/files/input/alonzo/genesis.alonzo.spec.json - why not reuse it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to put it in cardano-cli/test/cardano-cli-test/files/input/byron/genesis.byron.spec.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same we already have conway genesis in repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, we already have shelley genesis in cardano-cli/test/cardano-cli-test/files/input/shelley/genesis/genesis.spec.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants