Clarify documentation and properties of reduceChangeOutputs.
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
commented
Apr 6, 2020
jonathanknowles
commented
Apr 6, 2020
Justification: this name is consistent with the description and behaviour of the function, which is to reduce each of the change outputs, rather than to perform any rebalancing per se.
Includes worked examples.
Relocate examples so that they are next to relevant explanations. Add a section on handling insufficient change.
jonathanknowles
force-pushed
the
jonathanknowles/reduce-change-outputs
branch
from
5b610f9
to
32ea203
Compare
Test that: - Generation produces valid coins. - Shrinking produces valid coins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#18
#21
#22
Summary
This PR:
reduceChangeOutputs, adding examples.reduceChangeOutputsonly produces valid coins.