Formal Spec Syncing from Audit Issues #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
approved these changes
Sep 16, 2020
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/STS/Deleg.hs
Outdated
Show resolved
Hide resolved
| @@ -1240,40 +1241,52 @@ \subsection{Verifiable Random Function} | |||
|
|
|||
| \begin{figure} | |||
| \emph{VRF helper function} | |||
| \begin{align*} | |||
| & \fun{poolIDfromBHBody} \in \BHBody \to \KeyHash_{pool} \\ | |||
There was a problem hiding this comment.
The nomenclature is maybe a bit confusing here, since the issuer is not necessarily a pool. So I would go with issuerID or similar
There was a problem hiding this comment.
that's a good point, thank you! I would like to keep the name the same between the formal spec and the code, and I know that poolIDfromBHBody is being used already downstream (db sync uses it), but I can just give folks a heads up.
There was a problem hiding this comment.
I've deprecated poolIDfromBHBody and made an identical issuerIDfromBHBody.
…er/STS/Deleg.hs Co-authored-by: Nicholas Clarke <nicholas.clarke@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some small inconsistencies between the formal spec and the implementation.
closes #1776
closes #1808
closes #1811
closes #1820