Value serialisation fixes #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redxaxder
reviewed
Dec 3, 2020
shelley-ma/shelley-ma-test/src/Test/Cardano/Ledger/ShelleyMA/Serialisation/Roundtrip.hs
Outdated
Show resolved
Hide resolved
redxaxder
reviewed
Dec 3, 2020
mrBliss
reviewed
Dec 3, 2020
shelley-ma/shelley-ma-test/src/Test/Cardano/Ledger/ShelleyMA/Serialisation/Roundtrip.hs
Outdated
Show resolved
Hide resolved
|
|
||
| -- ============================================================ | ||
| -- EraIndex parameterized generators for each type family | ||
|
|
||
| genTxBody :: EraIndex e -> Gen(TxBody e) | ||
| genTxBody :: EraIndex e -> Gen (TxBody e) |
shelley-ma/shelley-ma-test/src/Test/Cardano/Ledger/ShelleyMA/Serialisation/Roundtrip.hs
Outdated
Show resolved
Hide resolved
shelley-ma/shelley-ma-test/src/Test/Cardano/Ledger/ShelleyMA/Serialisation/Roundtrip.hs
Outdated
Show resolved
Hide resolved
nc6
force-pushed
the
nc/value-serialisation
branch
2 times, most recently
from
84ef213
to
bfd1d89
Compare
Split in a separate commit.
nc6
force-pushed
the
nc/value-serialisation
branch
from
b82d6a3
to
e9ec17a
Compare
Rather than using prune, we instead use `valueFromList` to construct these directly. Also add some shrinkers for values.
Also print out the offending token on a failed parse.
These used some custom generators, which generated invalid values.
nc6
force-pushed
the
nc/value-serialisation
branch
from
8b8f4a1
to
237f6fd
Compare
dcoutts
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
roundtripAnn TxBodyin Mary goes from ~10s to ~1s)UInt64would not decode as coins.