rename CDDL timelock variable names #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency, we are going to uniformly use "invalid_before" and "invalid_hereafter" to denote the half open validity intervals [invalid_before, invalid_hereafter).
JaredCorduan
force-pushed
the
jc/rename-cddl-timelock-vars
branch
from
9e85332
to
7931dc8
Compare
nc6
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, we are going to uniformly use
invalid_beforeandinvalid_hereafterto denote the half open validity intervals[invalid_before, invalid_hereafter). I know that folks have strong and contrary opinions about these names, but right now consistency is what we need most.