Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to cabal.project #2595

Closed

Conversation

kk-hainq
Copy link
Contributor

Minor things I found while bumping dependencies elsewhere:

  • Point flat back to its original repository (bug fix merged).
  • Remove GHC options on removed packages.

@JaredCorduan
Copy link
Contributor

as always, thank you @kk-hainq for your help! I don't understand the hydra error, the log says "All 460 tests passed (1224.75s)". 🤔

- Point flat back to its original repository (bug fix merged).
- Remove ghc options on removed packages.
@kk-hainq kk-hainq force-pushed the improve-cabal-project branch from 9f4a0ff to 43b1b4d Compare January 4, 2022 18:20
@kk-hainq
Copy link
Contributor Author

kk-hainq commented Jan 4, 2022

@JaredCorduan I've rebased and it's gone now! The ormolu one seems stuck, but hopefully not required.

@JaredCorduan
Copy link
Contributor

@JaredCorduan I've rebased and it's gone now! The ormolu one seems stuck, but hopefully not required.

great, thanks again! the ormolu action is actually required, but I'll figure out what it takes to get past it

@JaredCorduan
Copy link
Contributor

JaredCorduan commented Jan 4, 2022

Actually, that ormolu check is the old one, and should not be required. The new ormolu check is inside the "Haskell CI" action, which I don't see in the list of checks.

it's as though https://github.com/input-output-hk/cardano-ledger/pull/2499/files never happened. which is weird, because your fork is up to date.

@kk-hainq
Copy link
Contributor Author

kk-hainq commented Jan 4, 2022

@JaredCorduan I've faced odd CI situations on a few first PRs in other repositories as well. Can you help cherry-pick 43b1b4de603f520146f2aaa6f8cba27ed4c46f6d to another branch and open a new PR for it? :(

@JaredCorduan
Copy link
Contributor

@JaredCorduan I've faced odd CI situations on a few first PRs in other repositories as well. Can you help cherry-pick 43b1b4de603f520146f2aaa6f8cba27ed4c46f6d to another branch and open a new PR for it? :(

absolutely @kk-hainq ! The only reason I didn't do that immediately was because I wanted to learn what was going wrong so that accepting PRs from forks would be easy in the future. Which is the whole reason for https://github.com/input-output-hk/cardano-ledger/pull/2499/files But I'm more than happy to get this across the line and see what happens next time.

@kk-hainq
Copy link
Contributor Author

kk-hainq commented Jan 4, 2022

Sure, thanks! I can hunt typos with my clones when you need more experiments...

@JaredCorduan
Copy link
Contributor

replaced by #2600

@kk-hainq kk-hainq deleted the improve-cabal-project branch January 4, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants