-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements to cabal.project #2595
Conversation
as always, thank you @kk-hainq for your help! I don't understand the hydra error, the log says "All 460 tests passed (1224.75s)". 🤔 |
- Point flat back to its original repository (bug fix merged). - Remove ghc options on removed packages.
9f4a0ff
to
43b1b4d
Compare
@JaredCorduan I've rebased and it's gone now! The |
great, thanks again! the ormolu action is actually required, but I'll figure out what it takes to get past it |
Actually, that ormolu check is the old one, and should not be required. The new ormolu check is inside the "Haskell CI" action, which I don't see in the list of checks. it's as though https://github.com/input-output-hk/cardano-ledger/pull/2499/files never happened. which is weird, because your fork is up to date. |
@JaredCorduan I've faced odd CI situations on a few first PRs in other repositories as well. Can you help cherry-pick |
absolutely @kk-hainq ! The only reason I didn't do that immediately was because I wanted to learn what was going wrong so that accepting PRs from forks would be easy in the future. Which is the whole reason for https://github.com/input-output-hk/cardano-ledger/pull/2499/files But I'm more than happy to get this across the line and see what happens next time. |
Sure, thanks! I can hunt typos with my clones when you need more experiments... |
replaced by #2600 |
Minor things I found while bumping dependencies elsewhere: