Add translation context to translate from Byron to Shelley #3164
Conversation
bartfrenk
force-pushed
the
bartfrenk/3976/translation-context-shelley
branch
5 times, most recently
from
58725b7
to
bb4bd92
Compare
There was a problem hiding this comment.
This looks great to me, thank you @bartfrenk ! Could you add something to the CHANGELOG about this change? thanks!
|
|
bartfrenk
force-pushed
the
bartfrenk/3976/translation-context-shelley
branch
3 times, most recently
from
6afd52c
to
e450dba
Compare
|
@bartfrenk thanks again! Should I merge this as soon an CI clears? (I don't plan on letting the darwin failure stop us from merging). I'll probably squash all the commits (they started out as logical units, but appeasing CI caused it to be a bit scattered :) ) |
bartfrenk
force-pushed
the
bartfrenk/3976/translation-context-shelley
branch
3 times, most recently
from
0b8bb44
to
13a02b0
Compare
bartfrenk
force-pushed
the
bartfrenk/3976/translation-context-shelley
branch
2 times, most recently
from
844103a
to
eb54442
Compare
bartfrenk
force-pushed
the
bartfrenk/3976/translation-context-shelley
branch
from
eb54442
to
1e3c099
Compare
There was a problem hiding this comment.
Ledger has changed since this PR was originally opened.
In #3224 we switched parameterization of ShelleyGenesis from era to crypto. Same thing is needed for FromByronTransitionContext, since that type is only valid for ShelleyEra. Also TranslateEra instances has been removed, also for the reason listed above.
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
bartfrenk
force-pushed
the
bartfrenk/3976/translation-context-shelley
branch
from
a323075
to
919d8a7
Compare
This PR does two things:
TranslationContextfor theShelleyErato allow for translating from Byron into the first Shelley era.It removes theDone in Mempool: Bound ex units of chosen transactions when forging new block ouroboros-network#3224TranslateErainstances forShelleyGenesis.Closes IntersectMBO/ouroboros-consensus#409. In short, it is required for removing the entire
ShelleyGenesisvalue from theShelleyLedgerConfiginouroboros-consensus. Closes IntersectMBO/ouroboros-consensus#409.There is a PR in ouroboros-consensus: IntersectMBO/ouroboros-network#4091 which require the (backported) changes from this PR.