Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PParams for Conway #3498

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Add PParams for Conway #3498

merged 1 commit into from
Jul 20, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jun 28, 2023

Description

Add PParams for Conway

Fixes #3146

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Voting thresholds need some work still. There is a related spec PR was opened earlier today: IntersectMBO/formal-ledger-specifications#134

eras/conway/impl/cardano-ledger-conway.cabal Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw mentioned this pull request Jul 3, 2023
9 tasks
@Soupstraw Soupstraw force-pushed the aniketd/conway-certs-3442 branch 5 times, most recently from 193fb95 to d7b462f Compare July 7, 2023 10:26
@Soupstraw
Copy link
Contributor

LGTM, good job @aniketd!

@Soupstraw Soupstraw requested a review from lehins July 7, 2023 11:13
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add:

  • roundtrip tests for PParams and PParamsUpdates
  • CDDL tests and spec for PParamsUpdates

There was a few bugs that I caught with regards to serialization, so tests would help us catch them and possibly others

eras/babbage/impl/CHANGELOG.md Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the aniketd/conway-certs-3442 branch 7 times, most recently from bc895b7 to 8dee5f0 Compare July 19, 2023 09:38
@Soupstraw Soupstraw requested a review from lehins July 19, 2023 09:38
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just wondering about the minimumAVS param that appears in the spec but not in the implementation, but probably something that I missed.

@teodanciu teodanciu mentioned this pull request Jul 19, 2023
9 tasks
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, check that the version of cardano-ledger-conway is more than 1.6.1.1 (either by changing it in this PR or by rebasing, whichever is needed at the time of merging)
Actually nevermind, 1.6.1.1 is not on chap, my mistake (unless... someone bumps to 1.6.1.1 and releases to chap before you merge this 😆 )

@Soupstraw Soupstraw enabled auto-merge (rebase) July 19, 2023 16:06
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff

@Soupstraw Soupstraw merged commit d5a6505 into master Jul 20, 2023
8 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/conway-certs-3442 branch July 20, 2023 14:36
@lehins lehins restored the aniketd/conway-certs-3442 branch July 21, 2023 09:01
@lehins lehins deleted the aniketd/conway-certs-3442 branch July 21, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new Conway protocol parameters
4 participants