Add a function registerInState to EraTransition
#4023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
reviewed
Jan 30, 2024
dnadales
force-pushed
the
dnadales/consensus/899-factor-out-application-of-transition-config
branch
from
8ee3dda to
8aaffc5
Compare
dnadales
force-pushed
the
dnadales/consensus/899-factor-out-application-of-transition-config
branch
from
3911457 to
ff608c6
Compare
dnadales
commented
Jan 30, 2024
amesgen
reviewed
Jan 31, 2024
dnadales
force-pushed
the
dnadales/consensus/899-factor-out-application-of-transition-config
branch
from
ff608c6 to
6a85fc0
Compare
dnadales
changed the title
registerInState to EraTransitionregisterInState to EraTransition
dnadales
force-pushed
the
dnadales/consensus/899-factor-out-application-of-transition-config
branch
from
193254c to
e36ed8f
Compare
lehins
requested changes
Jan 31, 2024
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
PR looks great. Just some changelog entries and version+bounds adjustments.
lehins
approved these changes
Jan 31, 2024
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Thank you!! This looks great.
Makes me happy to see improvements to this interface
... which allows to inject transition configuration data in the given `NewEpochState`. This change allows the Ledger to define this logic in this component without needing to do it in the Consensus layer. In this way, we improve the separation of concerns.
This allows the `ThreadNet` tests in Consensus to use `injectIntoTestState` after creating the initial state.
... stating that no funds or delegates are registered by this function.
Functions `registerInitialFunds`, `registerInitialStaking`, `registerInitialDReps`, and `registerDelegs` were used by the Consensus code, which now relies on `injectIntoTestState`.
lehins
force-pushed
the
dnadales/consensus/899-factor-out-application-of-transition-config
branch
from
105b848 to
ba5a9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which allows to inject transition configuration data in the given
NewEpochState.This change allows the Ledger to define this logic in this component without needing to do it in the Consensus layer. In this way, we improve the separation of concerns.
Part of IntersectMBO/ouroboros-consensus#899
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)