Run conformance on passTick
#4762
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a new `iteHook` field added to `ImpTestEnv`, we get an overridable function that can be executed within `trySubmitTx` for every submitted transaction. To override this hook we have `modifyImpInitHook` and `withHook` functions. We add a new `Conformance.Imp` module to `cardano-ledger-conformance` package, to import `Conway.Imp` and run those tests with a modified "hook" that runs the `LEDGER` rule from Agda on the Tx and `checkConformance` on the results. Additions: - `iteHook` field to `ImpTestEnv`. - `modifyImpInitHook` function to override the hook. - `withHook` helper function to use a different hook locally. - `impInitEnvL` and `impInitStateL` lenses. Changes: - Change `trySubmitTx` to run the hook for every submitted Tx.
Soupstraw
force-pushed
the
jj/imptest-conformance-passtick
branch
from
93cf1d8 to
e3a3a81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)