Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cddl for update_committee cold credential #4828

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Fix cddl for update_committee cold credential #4828

merged 5 commits into from
Jan 10, 2025

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Jan 10, 2025 •
edited
Loading

Description

Fixes #4823
and some small improvements in the process.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu requested a review from a team as a code owner January 10, 2025 11:08
@teodanciu teodanciu changed the title Fix cddl for update_committee cold credenteial Fix cddl for update_committee cold credential Jan 10, 2025
@teodanciu teodanciu force-pushed the td/fix-committee-cc-cddl branch from 53ca416 to 0156304 Compare January 10, 2025 11:57
aniketd
aniketd approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@teodanciu teodanciu force-pushed the td/fix-committee-cc-cddl branch from ff2aec1 to cc0d183 Compare January 10, 2025 15:22
Crypto2099
Crypto2099 approved these changes Jan 10, 2025
View reviewed changes
Copy link

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one other small error in the Conway.cddl that we should also try to address in this PR if possible.

eras/conway/impl/cddl-files/conway.cddl Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/CDDL.hs Outdated Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/fix-committee-cc-cddl branch from cc0d183 to d740606 Compare January 10, 2025 18:50
lehins
lehins approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!
Thank you!

@lehins lehins force-pushed the td/fix-committee-cc-cddl branch from d740606 to d4ff3a1 Compare January 10, 2025 19:35
@lehins lehins enabled auto-merge January 10, 2025 19:37
@lehins lehins merged commit 7573580 into master Jan 10, 2025
153 of 156 checks passed
@lehins lehins deleted the td/fix-committee-cc-cddl branch January 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@aniketd aniketd aniketd approved these changes

@Crypto2099 Crypto2099 Crypto2099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor typo in Conway Ledger CDDL
4 participants
@teodanciu @aniketd @lehins @Crypto2099