Ensure BabbageNonDisjointRefInputs is only checked for PlutusV3 scripts
#5011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
17 times, most recently
from
500251c to
a71d627
Compare
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
8 times, most recently
from
fbdc8e9 to
a462432
Compare
lehins
requested changes
May 10, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
It is mostly correct, but there are some issues with correct protocol version usage.
Other than that it looks great and great job on adding a new plutus test script and solving an issue where some scritps are not applicable for all plutus versions.
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxosSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
2 times, most recently
from
6e44a0c to
e7c6ca6
Compare
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
2 times, most recently
from
3df7fe5 to
0d5318e
Compare
lehins
reviewed
May 12, 2025
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
6 times, most recently
from
8bfce0d to
2f12961
Compare
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
5 times, most recently
from
136c851 to
387459d
Compare
lehins
approved these changes
May 15, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Very nice!
Couple of minor suggestions, but nothing critical.
eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
2 times, most recently
from
758e5e1 to
622fd9c
Compare
… scripts Add majorVersionAtLeast and majorVersionAtMost Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Soupstraw
force-pushed
the
jj/revert-non-disjoint-check
branch
from
622fd9c to
44de8ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables
BabbageNonDisjointRefInputsstarting from protocol version 11. This makes it possible to run PlutusV1/V2 scripts that require the same hash to appear in both the inputs and reference inputs.close #5009
close #5024
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).