Skip to content

Conversation

@Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Sep 30, 2025

Description

This PR adds a check that nOpts is not zero to ppuWellFormed.

resolves #5314

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw changed the title Wrapped nOpts in NonZero Added non-zero check for nOpts in ppuWellFormed from PV 11 Sep 30, 2025
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you.
Feel free to take it out of Draft and merge it at will

@Soupstraw Soupstraw marked this pull request as ready for review October 1, 2025 09:14
@Soupstraw Soupstraw requested a review from a team as a code owner October 1, 2025 09:14
@Soupstraw Soupstraw enabled auto-merge (rebase) October 1, 2025 09:15
@Soupstraw Soupstraw merged commit 59b52bb into master Oct 1, 2025
122 checks passed
@Soupstraw Soupstraw deleted the jj/nopt-nonzero branch October 1, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure nOpt is non-zero

3 participants