Remove size estimation from EncCBOR and EncCBORGroup
#5332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/remove-size-from-enc-cbor
branch
from
6921a0e to
092a7a0
Compare
lehins
force-pushed
the
lehins/remove-size-from-enc-cbor
branch
from
092a7a0 to
d048624
Compare
lehins
force-pushed
the
lehins/remove-size-from-enc-cbor
branch
from
d048624 to
ab71bf0
Compare
Soupstraw
approved these changes
Oct 8, 2025
eras/byron/ledger/impl/testlib/Test/Cardano/Chain/Block/Size.hs
Outdated
Show resolved
Hide resolved
eras/byron/ledger/impl/testlib/Test/Cardano/Chain/Block/Size.hs
Outdated
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/remove-size-from-enc-cbor
branch
2 times, most recently
from
fcf9ca3 to
4a6fdfc
Compare
lehins
force-pushed
the
lehins/remove-size-from-enc-cbor
branch
from
4a6fdfc to
2b8d0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the size estimation functionality that is not used by anyone and is blocking #5045
The main goal of this PR is to remove
Typeableconstraint fromEncCBOR, which is used withmkMemoizedand is needed for all lenses. RemovingTypeableconstraint unblocks the attempt at nested transactions that is being worked on in #5334Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).