Store Peras certificates in Ledger blocks #5409
Conversation
agustinmista
force-pushed
the
peras/store-certs-in-blocks
branch
from
7a92a86 to
a503668
Compare
| newtype DijkstraBbodyPredFailure era | ||
| = DijkstraBbodyPredFailure (ConwayBbodyPredFailure era) -- Temporary wrapper | ||
| deriving (Generic) |
There was a problem hiding this comment.
We could keep using a ConwayBbodyPredFailure until we actually need a different type, but I wanted to wrap it with a newtype to force the type checker to tell me in advance all the things we will need to manually redefine later on.
| transitionRules = | ||
| [ dijkstraBbodyTransition @era | ||
| -- TODO: these needs to be reintroduced | ||
| -- >> conwayBbodyTransition @era | ||
| -- >> alonzoBbodyTransition @era | ||
| ] |
There was a problem hiding this comment.
I'm having issues reintroducing these after defining the empty dijkstraBbodyTransition below (block body types between these transitions are now mismatched), but I'm not sure whether I should reconcile that via the TransitionRule interface or in some other way.
Maybe you could shed some light on this issue?
There was a problem hiding this comment.
This should be pretty much the same as Cardano.Ledger.Conway.BlockBody.Internal + s/Conway/Dijkstra/
There was a problem hiding this comment.
Hey @lehins! Thanks again for all the help. I made some progress introducing a new block body type for Dijkstra (extracted almost verbatim from that of Conway).
If you have some time, I left some comments on a couple of places I would appreciate some feedback on 🙏
After solving these issues, my idea was to open a separate PR targeting master to integrate all these Peras-agnostic changes as soon as possible.
Closes tweag/cardano-peras#163