Type-class-based CDDL generation #5419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Nov 14, 2025
aniketd
force-pushed
the
aniketd/cddl-type-classes
branch
5 times, most recently
from
8f8415d to
d435466
Compare
Soupstraw
reviewed
Nov 17, 2025
lehins
requested changes
Nov 18, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
I think this looks beautiful!
If you are able to apply all of my suggestions, then feel free to start basing definitions of other eras on this PR.
I'll take a look at it again first thing in the morning and if it's all good, I'll make sure it is merged right away.
aniketd
force-pushed
the
aniketd/cddl-type-classes
branch
from
d435466 to
60ee4d8
Compare
aniketd
commented
Nov 19, 2025
* Add new sub-libraries named `cddl`. * 3 typeclasses: HuddleRule, HuddleGroup and HuddleGRule * Proxy parameters are used to specify the era. * Polymorphic smart-constructors for all reusable huddle-specs Co-Authored-By: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
lehins
force-pushed
the
aniketd/cddl-type-classes
branch
from
60ee4d8 to
bf2d5f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New libraries named
cddlfor Shelley and Allegra to implement type-class-based cuddle definitions to generate .cddl files from.Follow-up PRs should implement for eras Mary-onwards.
This is the second phase in our efforts to address #5194
NOTE
codegenon CI is expected to FAIL, and its diff is important to know exactly what has changed in the new implementation.Checklist
Tests added or updated when needed.CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).