Skip to content

Add Imp test reproducer for #5418 #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

Add Imp test reproducer for #5418 #5434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49eb27c
Add Imp test
carlostome Nov 20, 2025
5c53fa7
Disable STS.RATIFY test
carlostome Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,48 @@ spoAndCCVotingSpec = do
logRatificationChecks constitutionActionId
passNEpochs 2
getConstitution `shouldNotReturn` newConstitution
-- https://github.com/IntersectMBO/cardano-ledger/issues/5418
-- TODO: Re-enable after issue is resolved, by removing this override
disableInConformanceIt "Committee proposals pass with inactive committee" $
whenPostBootstrap $ do
modifyPParams $ \pp ->
pp
& ppCommitteeMinSizeL .~ 2
& ppCommitteeMaxTermLengthL .~ EpochInterval 50
coldCommitteeActive <- KeyHashObj <$> freshKeyHash
coldCommitteeInactive <- KeyHashObj <$> freshKeyHash
startingEpoch <- getsNES nesELL
maxTermLength <- getsPParams ppCommitteeMaxTermLengthL
(drep, _, _) <- setupSingleDRep 1_000_000_000
(spo, _, _) <- setupPoolWithStake $ Coin 1_000_000_000
let
committeeMap =
[ (coldCommitteeActive, addEpochInterval startingEpoch maxTermLength)
, (coldCommitteeInactive, addEpochInterval startingEpoch $ EpochInterval 5)
]
initialCommittee <- getCommitteeMembers
committeeActionId <-
impAnn "Submit committee update"
. submitGovAction
$ UpdateCommittee
SNothing
initialCommittee
committeeMap
(0 %! 1)
submitYesVote_ (DRepVoter drep) committeeActionId
submitYesVote_ (StakePoolVoter spo) committeeActionId
passNEpochs 5
getCommitteeMembers `shouldReturn` Map.keysSet committeeMap
committeeProposal <-
elements
[ NoConfidence (SJust (GovPurposeId committeeActionId))
, UpdateCommittee (SJust (GovPurposeId committeeActionId)) Set.empty [] (0 %! 1)
]
committeeActionId2 <- submitGovAction committeeProposal
submitYesVote_ (DRepVoter drep) committeeActionId2
submitYesVote_ (StakePoolVoter spo) committeeActionId2
passNEpochs 2
getLastEnactedCommittee `shouldReturn` SJust (GovPurposeId committeeActionId2)

committeeExpiryResignationDiscountSpec ::
forall era.
Expand Down
4 changes: 3 additions & 1 deletion libs/cardano-ledger-conformance/test/Test/Cardano/Ledger/Conformance/Spec/Conway/Ratify.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ conformsToImplAccepted impl agda = property $ do

spec :: Spec
spec = describe "RATIFY" $ do
prop "STS" $ conformsToImplConstrained_ constrainedRatify
-- https://github.com/IntersectMBO/cardano-ledger/issues/5418
-- TODO: Re-enable after issue is resolved, by removing this override
xprop "STS" $ conformsToImplConstrained_ constrainedRatify
describe "Accepted" $ do
forM_
[ ("DRep", (dRepAccepted, Agda.acceptedByDRep))
Expand Down