Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Liveview leaves the terminal in a bad unusable state #1454

Closed
2072 opened this issue Jul 14, 2020 · 2 comments · Fixed by #1569
Closed

[BUG] - Liveview leaves the terminal in a bad unusable state #1454

2072 opened this issue Jul 14, 2020 · 2 comments · Fixed by #1569
Assignees
@denisshevchenko @CodiePP
Labels
bug Something isn't working

Comments

@2072
Copy link

2072 commented Jul 14, 2020

External

Summary
When using the Liveview and the node quits with an exception, or simply when pressing q since 1.15.1, the terminal is left unusable afterwards. One as to type stty sane in blind mode to get proper functionality again.

Opening and closing an editor such as vim or nano further fixes the terminal behavior as the cursor is still broken after stty sane.

Steps to reproduce
Steps to reproduce the behavior:

  1. Run the node in Liveview mode
  2. CTRL-C or q
  3. press return or try to type anything
  • The terminal doesn't react as expected (commands are executed but typed characters dont appear on screen)

Expected behavior
The terminal should be restored to its previous state just like after quitting vim or less or any other full screen terminal application.

System info (please complete the following information):

  • OS: Debian
  • Version: Buster
  • Node version: 1.15.1
@2072 2072 added the bug Something isn't working label Jul 14, 2020
@CodiePP
Copy link
Contributor

CodiePP commented Jul 20, 2020

we should probably add such a terminal reset command in the scripts.
reset should also do it.

@erikd
Copy link
Contributor

erikd commented Jul 21, 2020

Not everybody runs it via a script. This should be in the Haskell executable, maybe via a bracket construct.

@denisshevchenko denisshevchenko mentioned this issue Jul 27, 2020
Merged
@denisshevchenko denisshevchenko linked a pull request Jul 28, 2020 that will close this issue
CAD-1395: LiveView, correct quitting. #1569
Merged
iohk-bors bot added a commit that referenced this issue Aug 6, 2020
@iohk-bors
Merge #1569
076a00e 
1569: CAD-1395: LiveView, correct quitting. r=CodiePP a=denisshevchenko

This PR fixes a bug: #1454

There was a problem with terminal's state after quitting the node from the `LiveView`-mode: TUI artifacts and broken cursor. Now threads are stopping in another order, so the terminal has correct state after quitting.

Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
@iohk-bors iohk-bors bot closed this as completed in #1569 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denisshevchenko denisshevchenko

@CodiePP CodiePP

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CAD-1395: LiveView, correct quitting. IntersectMBO/cardano-node
5 participants
@2072 @erikd @denisshevchenko @kevinhammond @CodiePP