Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display the metrics dict in the output of kes-period-info command #3627

Closed
saratomaz opened this issue Feb 21, 2022 · 0 comments · Fixed by #3683
Closed

Always display the metrics dict in the output of kes-period-info command #3627

saratomaz opened this issue Feb 21, 2022 · 0 comments · Fixed by #3683
Assignees
Labels
area: kes-info comp: cardano-cli enhancement New feature or request tag: 1.34.0 type: bug Something is not working user type: internal Created by an IOG employee

Comments

@saratomaz
Copy link

saratomaz commented Feb 21, 2022

Internal

Area
cli command

Describe the feature you'd like
Always get the metrics dict as a output of the command, now is only retrieving the metrics on an "all valid" scenario.

Additional context / screenshots
"all valid" scenario example with the metrics

✓ The counters match what is in the node's protocol state
✓ The counters in the operational certificate and operational certificate issue counter file are the same
✓ Operational certificate's kes period is within the correct KES period interval
{
    "qKesNodeStateOperationalCertificateNumber": 6,
    "qKesCurrentKesPeriod": 404,
    "qKesOnDiskOperationalCertificateNumber": 6,
    "qKesRemainingSlotsInKesPeriod": 3760228,
    "qKesMaxKESEvolutions": 62,
    "qKesKesKeyExpiry": "2022-03-20T21:44:51Z",
    "qKesEndKesInterval": 434,
    "qKesStartKesInterval": 372,
    "qKesSlotsPerKesPeriod": 129600
}
@saratomaz saratomaz added the enhancement New feature or request label Feb 21, 2022
@saratomaz saratomaz changed the title Update output of kes-period-info command Always display the metrics dict in the output of kes-period-info command Feb 22, 2022
@newhoggy newhoggy self-assigned this Mar 2, 2022
@Jimbo4350 Jimbo4350 assigned cblp and unassigned newhoggy Mar 2, 2022
iohk-bors bot added a commit that referenced this issue Mar 14, 2022
3683: cardano-cli query kes-period-info: Always display metrics r=Jimbo4350 a=cblp

Resolves #3627 

Co-authored-by: Yuriy Syrovetskiy <yuriy.syrovetskiy@iohk.io>
iohk-bors bot added a commit that referenced this issue Mar 22, 2022
3683: cardano-cli query kes-period-info: Always display metrics r=Jimbo4350 a=cblp

Resolves #3627 

Co-authored-by: Yuriy Syrovetskiy <yuriy.syrovetskiy@iohk.io>
@iohk-bors iohk-bors bot closed this as completed in 3b587d1 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kes-info comp: cardano-cli enhancement New feature or request tag: 1.34.0 type: bug Something is not working user type: internal Created by an IOG employee
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants