Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Shelley era Tx body in CDDL format is not supported by some CLI commands #3688

Closed
mkoura opened this issue Mar 7, 2022 · 1 comment · Fixed by #4071
Closed

[BUG] - Shelley era Tx body in CDDL format is not supported by some CLI commands #3688

mkoura opened this issue Mar 7, 2022 · 1 comment · Fixed by #4071
Assignees
@Jimbo4350
Labels
API&CLI-Backlog bug Something isn't working comp: cardano-cli priority: critical Requires immediate attention. Critical issue that needs to be fixed ASAP and released as hotfix. priority highest issues to be worked on immediately type: regression A feature that worked before stoped working user type: internal Created by an IOG employee

Comments

@mkoura
Copy link
Contributor

mkoura commented Mar 7, 2022 •
edited
Loading

Internal if an IOHK staff member.

Area
Other Any other topic (Delegation, Ranking, ...).

Summary
Shelley era Tx body in CDDL format:

cardano-cli transaction build-raw --fee 0 --out-file test_transfer_all_funds_ci0_xrc_estimate_tx.body --tx-in d53a926ce885c6821ec475489be9d0fdade33969c0833e6205333046091a4488#1 --tx-out addr_test1vq98lqkgg36k78axnz5e2g8h44q7mcpsnku9tv7g9qmvwdguhqcu9+1000000000 --invalid-hereafter 28444 --cddl-format --shelley-era

It then cannot be e.g. signed:

cardano-cli transaction sign --tx-body-file test_transfer_all_funds_ci0_xrc_tx.body --testnet-magic 42 --signing-key-file addr_basic_ci0_1.skey --out-file test_transfer_all_funds_ci0_xrc_tx.signed

Command failed: transaction sign Error: Failed to decode neither the cli's serialisation format nor the ledger's CDDL serialisation format. TextEnvelope error: test_transfer_all_funds_ci0_xrc_tx.body: TextEnvelope type error: Expected one of: TxUnsignedByron, TxUnsignedShelley, TxBodyAllegra, TxBodyMary, TxBodyAlonzo Actual: Unwitnessed Tx ShelleyEra
TextEnvelopeCddl error: test_transfer_all_funds_ci0_xrc_tx.body: TextEnvelopeCddl type error: Expected one of: Witnessed Tx Byron, Witnessed Tx Shelley, Witnessed Tx AllegraEra, Witnessed Tx MaryEra, Witnessed Tx AlonzoEra, Unwitnessed Tx Byron, Unwitnessed Tx Shelley, Unwitnessed Tx AllegraEra, Unwitnessed Tx MaryEra, Unwitnessed Tx AlonzoEra Actual: Unwitnessed Tx ShelleyEra

Same for calculate-min-fee:

cardano-cli transaction calculate-min-fee --testnet-magic 42 --protocol-params-file /home/martink/Source/repos/cardano-node/state-cluster0/pparams-ybbq.json --tx-in-count 2 --tx-out-count 1 --byron-witness-count 0 --witness-count 1 --tx-body-file test_transfer_all_funds_ci0_xrc_estimate_tx.body

Command failed: transaction calculate-min-fee Error: Failed to decode neither the cli's serialisation format nor the ledger's CDDL serialisation format. TextEnvelope error: test_transfer_all_funds_ci0_xrc_estimate_tx.body: TextEnvelope type error: Expected one of: TxUnsignedByron, TxUnsignedShelley, TxBodyAllegra, TxBodyMary, TxBodyAlonzo Actual: Unwitnessed Tx ShelleyEra
TextEnvelopeCddl error: test_transfer_all_funds_ci0_xrc_estimate_tx.body: TextEnvelopeCddl type error: Expected one of: Witnessed Tx Byron, Witnessed Tx Shelley, Witnessed Tx AllegraEra, Witnessed Tx MaryEra, Witnessed Tx AlonzoEra, Unwitnessed Tx Byron, Unwitnessed Tx Shelley, Unwitnessed Tx AllegraEra, Unwitnessed Tx MaryEra, Unwitnessed Tx AlonzoEra Actual: Unwitnessed Tx ShelleyEra

System info (please complete the following information):

  • OS Name: Fedora
  • OS Version: 34
  • Node version:
cardano-node 1.34.1 - linux-x86_64 - ghc-8.10
git rev 73f9a746362695dc2cb63ba757fbcabb81733d23
@mkoura mkoura added the bug Something isn't working label Mar 7, 2022
mkoura added a commit to mkoura/cardano-node-tests that referenced this issue Mar 11, 2022
@mkoura
Smoke test for Shelley Tx with CDDL format
7e4edb7 
Tests presence of bug IntersectMBO/cardano-node#3688
@mkoura mkoura mentioned this issue Mar 11, 2022
Merged
@wcatz wcatz mentioned this issue May 3, 2022
Closed
@CarlosLopezDeLara CarlosLopezDeLara added the priority highest issues to be worked on immediately label Jun 13, 2022
@Jimbo4350 Jimbo4350 mentioned this issue Jun 21, 2022
Merged
@Jimbo4350
Copy link
Contributor

Fixed by 4071

iohk-bors bot added a commit that referenced this issue Jun 22, 2022
@iohk-bors @Jimbo4350
Merge #4071
2ddefad 
4071: Fix cddl format for shelley and byron eras r=Jimbo4350 a=Jimbo4350

Fixes: #3688 

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@dorin100 dorin100 added type: regression A feature that worked before stoped working user type: internal Created by an IOG employee priority: critical Requires immediate attention. Critical issue that needs to be fixed ASAP and released as hotfix. comp: cardano-cli labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jimbo4350 Jimbo4350

Labels
API&CLI-Backlog bug Something isn't working comp: cardano-cli priority: critical Requires immediate attention. Critical issue that needs to be fixed ASAP and released as hotfix. priority highest issues to be worked on immediately type: regression A feature that worked before stoped working user type: internal Created by an IOG employee
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cddl format for shelley and byron eras IntersectMBO/cardano-node
4 participants
@mkoura @Jimbo4350 @dorin100 @CarlosLopezDeLara