Add a new node config entry: TestShelleyHardForkAtVersion #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting this, e.g. TestShelleyHardForkAtVersion: 1 Should cause the hard fork to occur when the protocol major version eraches this value, rather than the default of 2. This allows a simpler test setup. Otherwise, given that Byron genesis always starts at protocol version 0, it needs two protocol updates (includng a node restart) to get to the hard fork.
mrBliss
approved these changes
Jun 25, 2020
| @@ -173,7 +174,11 @@ mkConsensusProtocolCardano NodeByronProtocolConfiguration { | |||
| -- Version 1 is Byron with Ouroboros Permissive BFT | |||
| -- Version 2 is Shelley | |||
| -- | |||
| Nothing -> Consensus.NoHardCodedTransition 2 | |||
| -- But we also provide an override to allow for simpler test setups | |||
| -- such as triggering at the 0 -> 1 transition . | |||
There was a problem hiding this comment.
Suggested change
| -- such as triggering at the 0 -> 1 transition . | |
| -- such as triggering at the 0 -> 1 transition. |
intricate
approved these changes
Jun 25, 2020
kantp
approved these changes
Jun 25, 2020
|
bors merge |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this, e.g.
TestShelleyHardForkAtVersion: 1
Should cause the hard fork to occur when the protocol major version
eraches this value, rather than the default of 2.
This allows a simpler test setup. Otherwise, given that Byron genesis
always starts at protocol version 0, it needs two protocol updates
(includng a node restart) to get to the hard fork.