Add command for converting various Byron keys to their Shelley counterpart #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
requested review from
dcoutts,
erikd,
Jimbo4350,
mrBliss and
newhoggy
as code owners
intricate
commented
Jul 17, 2020
| !Text | ||
| -- ^ Text representation of the parse error. Unfortunately, the actual | ||
| -- error type isn't exported. | ||
| | ShelleyKeyCmdDeserialiseByronVerKeyError |
There was a problem hiding this comment.
I feel like it'd be nicer to instead have something like ShelleyKeyCmdCborDecoderError !DecoderError.
intricate
force-pushed
the
intricate/1467-convert-byron-keys
branch
from
37fb8fa
to
358b052
Compare
8 tasks
dcoutts
approved these changes
Jul 17, 2020
Comment on lines
291
to
295
| <$> pITNKeyFIle | ||
| <*> pMaybeOutputFile | ||
|
|
||
| pITNKeyFile :: Parser ITNKeyFile | ||
| pITNKeyFile = pITNSigningKeyFile <|> pITNVerificationKeyFile | ||
| pITNKeyFIle :: Parser ITNKeyFile | ||
| pITNKeyFIle = pITNSigningKeyFile <|> pITNVerificationKeyFile |
There was a problem hiding this comment.
Accidental name change ("I" vs "i").
Additionally, move key conversion commands such as "address convert" and "stake-address convert-itn-key" under this new "key" command.
And consolodate the special-purpose parsers to be next to each other.
Extended ed25519 (bip32) key variants for stake keys, for genesis keys and for genesis delegate keys. The stake extended keys are useful for importing keys from HD wallets, and for ITN extended keys. The genesis and genesis delgate ones are useful for working with Byron legacy keys, which all used extended signing keys (for no good reason).
The existing command supported Byron payment signing keys. Add conversion support for Byron genesis and genesis delegate keys. Also support both signing and verification keys. And also support the legacy Byron format for the signing keys. Adjust the existing special command for the base64 genesis verification key to take the base64 as a flag rather than in a file. Also adjust the ITN conversion to use the same types as the above.
dcoutts
force-pushed
the
intricate/1467-convert-byron-keys
branch
from
07de813
to
ee23c34
Compare
dcoutts
changed the title
|
bors merge |
|
I can't approve since I originally opened this PR, but LGTM 💯 |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for converting:
Support either verification or signing keys.
Support current or legacy (ie SL) formats.
Also add special conversion for Byron genesis verification keys in base64,
as they appear in the Byron genesis file as
issuerPK.