Use a released version of cborg #1711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency on cborg was pinned to an unreleased revision to bring in <well-typed/cborg#223>. That PR has been included in `cborg-0.2.3.0`, so we can remove the dependency pin in favour of bumping the lower version bound on the dependency. Instead of using 0.2.3 as the lower version bound, bump it to >= 0.2.4, as this version is compatible with the last version of the `primitive` package, which will soon be needed by `cardano-ledger-specs`, see <IntersectMBO/cardano-ledger#1785>. Another advantage of using a released version is that the package will now be stored in the global cabal store and shared between projects (although that will also be the case for source dependencies in Cabal 3.4.0.0).
mrBliss
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350 and
newhoggy
as code owners
Merged
|
No longer needed, since #1696 was merged |
|
Ughh, I mentioned the wrong PR in my last comment 🤦. Thanks for cleaning this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on cborg was pinned to an unreleased revision to bring in
well-typed/cborg#223. That PR has been included in
cborg-0.2.3.0, so we can remove the dependency pin in favour of bumping thelower version bound on the dependency.
Instead of using 0.2.3 as the lower version bound, bump it to >= 0.2.4, as this
version is compatible with the last version of the
primitivepackage, whichwill soon be needed by
cardano-ledger-specs, seeIntersectMBO/cardano-ledger#1785.
Another advantage of using a released version is that the package will now be
stored in the global cabal store and shared between projects (although that will
also be the case for source dependencies in Cabal 3.4.0.0).