Add simple mainnet node script #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
intricate,
mrBliss and
newhoggy
as code owners
|
Seems to work just fine, but perhaps it'd be better to use a db in a specific directory rather than a new temp directory, created each time the script is invoked? The old mainnet script stored it in |
Jimbo4350
force-pushed
the
jordan/add-mainnet-script
branch
from
7a10511
to
d1a567a
Compare
edsko
approved these changes
Sep 15, 2020
newhoggy
approved these changes
Sep 15, 2020
Jimbo4350
force-pushed
the
jordan/add-mainnet-script
branch
from
d1a567a
to
80f5609
Compare
@newhoggy Ah yes. Just added |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.