Replace panic with fail in JSON parsers #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cardano.Node.Types * Cardano.Node.Orphans * Cardano.Tracing.OrphanInstances.Common
newhoggy
force-pushed
the
newhoggy/replace-panic-json-parsers
branch
from
6f5822d
to
994aa46
Compare
newhoggy
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350 and
mrBliss
as code owners
Jimbo4350
approved these changes
Nov 13, 2020
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 13, 2020
2088: Replace panic with fail in JSON parsers r=dcoutts a=newhoggy Attempt to take #1955 to fruition Replace panic with fail in JSON parsers in: * Cardano.Node.Types * Cardano.Node.Orphans * Cardano.Tracing.OrphanInstances.Common Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 13, 2020
2088: Replace panic with fail in JSON parsers r=intricate a=newhoggy Attempt to take #1955 to fruition Replace panic with fail in JSON parsers in: * Cardano.Node.Types * Cardano.Node.Orphans * Cardano.Tracing.OrphanInstances.Common Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
intricate
approved these changes
Nov 13, 2020
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 13, 2020
2088: Replace panic with fail in JSON parsers r=intricate a=newhoggy Attempt to take #1955 to fruition Replace panic with fail in JSON parsers in: * Cardano.Node.Types * Cardano.Node.Orphans * Cardano.Tracing.OrphanInstances.Common Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to take #1955 to fruition
Replace panic with fail in JSON parsers in: