Prefer Shelley CLI commands over Byron ones where they clash #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
requested review from
erikd,
intricate,
mrBliss and
newhoggy
as code owners
We have done a fair bit of shuffling of CLI commands over time, and have kept the old commands for backwards compatibility. There was a name clash over the "genesis" top level command: between the Shelley command and the backwards compat Byron command. Reorder the command lists so we prefer the new Shelley commands, and generally the new ones over the old ones.
dcoutts
force-pushed
the
dcoutts/cli-fix-command-precedence
branch
from
5cd1481
to
8c29016
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 30, 2020
2145: Prefer Shelley CLI commands over Byron ones where they clash r=dcoutts a=dcoutts We have done a fair bit of shuffling of CLI commands over time, and have kept the old commands for backwards compatibility. There was a name clash over the "genesis" top level command: between the Shelley command and the backwards compat Byron command. Reorder the command lists so we prefer the new Shelley commands, and generally the new ones over the old ones. Co-authored-by: Duncan Coutts <duncan@well-typed.com>
Jimbo4350
approved these changes
Nov 30, 2020
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have done a fair bit of shuffling of CLI commands over time, and have
kept the old commands for backwards compatibility.
There was a name clash over the "genesis" top level command: between the
Shelley command and the backwards compat Byron command.
Reorder the command lists so we prefer the new Shelley commands, and
generally the new ones over the old ones.