Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement certifying and withdrawing Plutus script tests #3318

Merged
merged 6 commits into from
Dec 24, 2021
Merged

Implement certifying and withdrawing Plutus script tests #3318

merged 6 commits into from
Dec 24, 2021
+1,133 −178

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch 4 times, most recently from bb6a512 to 3284bd0 Compare October 27, 2021 16:53
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 27, 2021 16:54
newhoggy
newhoggy reviewed Oct 28, 2021
View reviewed changes
cardano-cli/test/Test/Cli/JSON.hs
import Hedgehog.Gen as Gen
import Hedgehog.Range as Range

-- TODO: Move to cardano-api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep for a follow up PR

@newhoggy
Copy link
Contributor

There is a test failure that needs looking into:

          632 ┃       Just rwds -> (rwds > 0) === True >> return rwds
              ┃       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              ┃       │ ━━━ Failed (- lhs) (+ rhs) ━━━
              ┃       │ - False
              ┃       │ + True

@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch from 3284bd0 to 7454971 Compare November 1, 2021 14:11
@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch 2 times, most recently from 3d213b5 to c0fd75d Compare November 2, 2021 14:40
@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch 7 times, most recently from ac4448f to c7f9215 Compare November 10, 2021 21:13
@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch from 73e66f3 to 7f2f950 Compare November 23, 2021 14:12
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 23, 2021
@iohk-bors @Jimbo4350
Merge #3318

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
d3a82f8 
3318: Implement certifying and withdrawing Plutus script tests r=Jimbo4350 a=Jimbo4350



Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 23, 2021

Timed out.

@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 23, 2021
@iohk-bors @Jimbo4350 @MarcFontaine
Merge #3318 #3384

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
6fb8f55 
3318: Implement certifying and withdrawing Plutus script tests r=Jimbo4350 a=Jimbo4350



3384: tx-generator: add loop.plutus example r=MarcFontaine a=MarcFontaine

Add a simple loop Plutus script.

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 23, 2021

Canceled.

@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch 2 times, most recently from 9f397ae to 7f2f950 Compare November 24, 2021 15:05
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 24, 2021
@iohk-bors @Jimbo4350
Merge #3318

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
89f6698 
3318: Implement certifying and withdrawing Plutus script tests r=Jimbo4350 a=Jimbo4350



Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 24, 2021

Build failed:

@Jimbo4350
Refactor Plutus staking example scripts

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
5a23eb4
@Jimbo4350
Add JSON instances for StakeAddress, Hash BlockHeader, AnyCardanoEra …

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
f9a1276 
…and Hash StakePoolKey
@Jimbo4350
Add FromJSON instances for BlockNo, QueryTipLocalStateOutput and Dele…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
b1a4e64 
…gationsAndRewards
@Jimbo4350
Add a Plutus certifying and rewarding script test to cardano-testnet

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
8a6e29b
@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch from 7f2f950 to 7f58674 Compare December 23, 2021 14:12
@Jimbo4350
Remove AnyCardanoEra JSON instance from bench

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
277a2fa
@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch from 7f58674 to 277a2fa Compare December 23, 2021 14:34
@Jimbo4350
Ignore certifying and withdrawing Plutus tests on MacOS

Verified

This commit was signed with the committer’s verified signature. The key has expired.
RomainMuller Romain Marcadier
GPG key ID: BB3E21324F18BCB1
Expired
Verified
Learn about vigilant mode
a37ec21
@Jimbo4350 Jimbo4350 force-pushed the jordan/certifying-withdrawing-plutus-script-ci branch from 5c13630 to a37ec21 Compare December 23, 2021 16:44
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 23, 2021
@iohk-bors @Jimbo4350
Merge #3318

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bdbac85 
3318: Implement certifying and withdrawing Plutus script tests r=Jimbo4350 a=Jimbo4350



Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 23, 2021

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from DavidEichmann, dcoutts, erikd, JaredCorduan, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

newhoggy
newhoggy reviewed Dec 24, 2021
View reviewed changes
cardano-testnet/test/Main.hs
[ H.testProperty "Spec.Plutus.Direct.TxInLockingPlutus" Spec.Plutus.Direct.TxInLockingPlutus.hprop_plutus
-- This hangs on Windows for an unknown reason
[ -- Fails to meet deadline on MacOS for an unknown reason
ignoreOnMac "Spec.Plutus.Direct.CertifyingAndWithdrawingPlutus" Spec.Plutus.Direct.CertifyingAndWithdrawingPlutus.hprop_plutus_certifying_withdrawing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 24, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 28c34d8 into master Dec 24, 2021
@iohk-bors iohk-bors bot deleted the jordan/certifying-withdrawing-plutus-script-ci branch December 24, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy

@deepfire deepfire

@MarcFontaine MarcFontaine

@DavidEichmann DavidEichmann

@dcoutts dcoutts

@erikd erikd

@JaredCorduan JaredCorduan

@nc6 nc6

@denisshevchenko denisshevchenko

@jutaro jutaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jimbo4350 @newhoggy @deepfire @MarcFontaine