CAD-3638: extended trace-forward library. #3342
Merged
+1,424
−847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
requested review from
DavidEichmann,
dcoutts,
deepfire,
erikd,
JaredCorduan,
Jimbo4350,
jutaro,
nc6 and
newhoggy
as code owners
denisshevchenko
force-pushed
the
cad-3638-forward-protocols
branch
3 times, most recently
from
048d333 to
8ce77a5
Compare
43 tasks
denisshevchenko
changed the title
denisshevchenko
force-pushed
the
cad-3638-forward-protocols
branch
from
6c5f61f to
ca8c45d
Compare
denisshevchenko
force-pushed
the
cad-3638-forward-protocols
branch
2 times, most recently
from
f3941cc to
867854f
Compare
denisshevchenko
force-pushed
the
cad-3638-forward-protocols
branch
from
867854f to
9144b84
Compare
deepfire
approved these changes
Nov 11, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 11, 2021
3342: CAD-3638: extended trace-forward library. r=deepfire a=denisshevchenko Since both `trace-forward` and `datapoint-forward` specify node-specific protocols, it's better to combine them into one package. This package will be used by `trace-dispatcher` library for forwarding `TraceObject`s and `DataPoint`s from the node to external acceptor app (for example, `cardano-tracer` or `cardano-wallet`). Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
|
Timed out. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 11, 2021
3342: CAD-3638: extended trace-forward library. r=denisshevchenko a=denisshevchenko Since both `trace-forward` and `datapoint-forward` specify node-specific protocols, it's better to combine them into one package. This package will be used by `trace-dispatcher` library for forwarding `TraceObject`s and `DataPoint`s from the node to external acceptor app (for example, `cardano-tracer` or `cardano-wallet`). Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
|
Timed out. |
denisshevchenko
force-pushed
the
cad-3638-forward-protocols
branch
from
9144b84 to
7551c6b
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both
trace-forwardanddatapoint-forwardspecify node-specific protocols, it's better to combine them into one package. This package will be used bytrace-dispatcherlibrary for forwardingTraceObjects andDataPoints from the node to external acceptor app (for example,cardano-tracerorcardano-wallet).