New tracing #3450
Merged
New tracing #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
deepfire
force-pushed
the
new-tracing
branch
from
23b4688 to
1a30c62
Compare
deepfire
force-pushed
the
new-tracing
branch
from
dfa8829 to
024922e
Compare
Jimbo4350
requested changes
Dec 21, 2021
deepfire
force-pushed
the
new-tracing
branch
2 times, most recently
from
e694703 to
184ecbe
Compare
deepfire
force-pushed
the
new-tracing
branch
7 times, most recently
from
3cb7c9e to
844b9e2
Compare
Jimbo4350
requested changes
Jan 7, 2022
Jimbo4350
reviewed
Jan 10, 2022
deepfire
requested review from
erikd,
JaredCorduan,
MarcFontaine,
nc6 and
newhoggy
as code owners
jutaro
approved these changes
Jan 12, 2022
Jimbo4350
reviewed
Jan 12, 2022
New Tracing Quickstart.md
Outdated
| @@ -0,0 +1,148 @@ | |||
| # New Tracing Quickstart | |||
There was a problem hiding this comment.
This shouldn't be at the top level.
There was a problem hiding this comment.
The idea was to temporarily increase visibility of the Quickstart for the new tracing system -- as we would like people to start playing with it.
But I guess it could live in doc/ as well.
deepfire
force-pushed
the
new-tracing
branch
2 times, most recently
from
b470c24 to
80f9527
Compare
Jimbo4350
requested changes
Jan 12, 2022
|
|
||
| namesStartupInfo :: StartupTrace blk -> [Text] | ||
| namesStartupInfo = \case | ||
| StartupInfo {} -> ["StartupInfo"] |
| , npcByronGenesisFileHash :: !(Maybe GenesisHash) | ||
| , npcByronReqNetworkMagic :: !RequiresNetworkMagic | ||
| , npcByronPbftSignatureThresh :: !(Maybe Double) | ||
| npcByronGenesisFile :: !GenesisFile |
There was a problem hiding this comment.
A perfect example of my we enforce not aligning code. It introduces unnecessary diff.
Jimbo4350
approved these changes
Jan 12, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates the new tracing system in
cardano-node:trace-dispatchercardano-nodetrace-analyzertx-generatortrace-forwardtrace-resourcesNote: I've only just opened the PR -- all the heavy work was done by @jutaro and @denisshevchenko, who get all the credit!
Note: this branch has a very squashed history, for many months of development -- for the historic branch, please see https://github.com/input-output-hk/cardano-node/tree/tracing-master-history
How to try out?
Just run
./scripts/lite/mainnet-new-tracing.sh-- which uses this configuration: https://github.com/input-output-hk/cardano-node/tree/new-tracing/configuration/cardano/mainnet-config-new-tracing.yaml#L41-L82