-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement kes-period-info command #3459
Conversation
d429738
to
7871b22
Compare
7316c57
to
2828edf
Compare
11d1eca
to
6d480c1
Compare
I did some more testing just now and am a little bit concerned about the presentation of the command: For example when I run this against my stake pool:
I think if the KES period is behind, it is noteworthy, but not necessarily wrong to warrant an error. For example a SPO might be worried their stake pool is not producing blocks, and try to use the command to verify if they've cycled their keys incorrectly. The command gives them an error that makes them feel like they've cycled their keys incorrectly, but they actually did it correctly, but they were just unlucky to not have produced blocks and the KES period is different only because the SPO is doing the query a few KES periods past when they cycled their keys. Not sure if it's possible, a useful thing would be printing when the current KES keys will expire. I think a good UI might look like this:
|
I definitely agree with the UI change, it should be diagnostic. |
6d480c1
to
91057f8
Compare
0f451be
to
7cb8931
Compare
getHotKey to retrieve KES key from op cert getKesPeriod to retrieve the KES period from an op cert getOpCertCount to retrieve the count from an op cert Modify readLeaderCredentialsSingleton to check that the supplied KES key matches the KES key specified in the operational certificate
of checks on the specified node operational certificate that your stake pool is currently using.
7cb8931
to
6a1baea
Compare
bors r+ |
Build succeeded: |
Wohoo whan will it be released? |
Resolves: #2551, #3257, #2558, #3556
Implement
kes-period-info
cli command that checks your operational certificate and certificate issue counter file are correct:It checks: