Update ouroboros-network & tracing changes #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350,
nc6 and
newhoggy
as code owners
coot
added
networking
coot
force-pushed
the
coot/p2p-trace-config
branch
from
f1feeb5 to
b45322e
Compare
coot
force-pushed
the
coot/p2p-trace-config
branch
from
b45322e to
bdace4a
Compare
coot
force-pushed
the
coot/p2p-trace-config
branch
from
bdace4a to
911f7c3
Compare
newhoggy
reviewed
Jan 16, 2022
newhoggy
reviewed
Jan 16, 2022
coot
force-pushed
the
coot/p2p-trace-config
branch
2 times, most recently
from
69dfdd1 to
4cd87ec
Compare
karknu
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
LGTM.
I'd like a newer ouroboros-network version once IntersectMBO/ouroboros-network#3535 is merged.
coot
force-pushed
the
coot/p2p-trace-config
branch
from
4cd87ec to
28dce18
Compare
coot
force-pushed
the
coot/p2p-trace-config
branch
from
28dce18 to
8a3f65a
Compare
Jimbo4350
requested changes
Jan 21, 2022
coot
force-pushed
the
coot/p2p-trace-config
branch
from
90f9b7a to
75d8f90
Compare
This change integrates the new `LocalTxMonitor` mini-protocol for `node-to-client` connections.
* TraceConnectionManager * TraceInboundGovernor * TracePeerSelection * TracePeerSelectionActions All of them are not chatty if network conditions are stable.
Peer selection counters should be logged if `tracePeerSelectionCounters` is set, not `tracePeerSelection`. Their name space should be `PeerSelectionCounters` not `PeerSelection`.
The network related tracers, has been codeowned by the networking team; let's preserve this for the new tracing system.
coot
force-pushed
the
coot/p2p-trace-config
branch
from
75d8f90 to
cfe3da0
Compare
newhoggy
approved these changes
Feb 1, 2022
Closed
Jimbo4350
approved these changes
Feb 1, 2022
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 1, 2022
3497: Update ouroboros-network & tracing changes r=coot a=coot Make the following traces on by default: * TraceConnectionManager * TraceInboundGovernor * TracePeerSelection * TracePeerSelectionActions All of them are not chatty if network conditions are stable. * Fix peer selection tracer. * Add transition tracers IntersectMBO/ouroboros-network#3571 Co-authored-by: Marcin Szamotulski <coot@coot.me> Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
|
Build failed: |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 1, 2022
3497: Update ouroboros-network & tracing changes r=coot a=coot Make the following traces on by default: * TraceConnectionManager * TraceInboundGovernor * TracePeerSelection * TracePeerSelectionActions All of them are not chatty if network conditions are stable. * Fix peer selection tracer. * Add transition tracers IntersectMBO/ouroboros-network#3571 Co-authored-by: Marcin Szamotulski <coot@coot.me> Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire, denisshevchenko, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Feb 3, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the following traces on by default:
All of them are not chatty if network conditions are stable.
IntersectMBO/ouroboros-network#3571