-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New shutdown-ipc tests #3508
New shutdown-ipc tests #3508
Conversation
991c2e4
to
9796e82
Compare
9796e82
to
0b35478
Compare
This has been happening on Mac in Nix, but runs okay in GH:
|
7850afb
to
8720562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -34,6 +35,7 @@ tests = do | |||
, H.testProperty "Spec.Plutus.SubmitApi.TxInLockingPlutus" Spec.Plutus.SubmitApi.TxInLockingPlutus.hprop_plutus | |||
, ignoreOnWindows "Spec.Plutus.Direct.ScriptContextEquality" Spec.Plutus.Direct.ScriptContextEquality.hprop_plutus_script_context_equality | |||
, ignoreOnWindows "Spec.Plutus.Direct.ScriptContextEqualityMint" Spec.Plutus.Direct.ScriptContextEqualityMint.hprop_plutus_script_context_mint_equality | |||
, ignoreOnWindows "Spec.Shutdown" Spec.Shutdown.hprop_shutdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just put a comment saying that currently there is a blocking call on Windows that prevents graceful shutdown (or something to that effect) and that we currently aren't testing the shutdown IPC flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
8720562
to
c4cd6ec
Compare
bors merge |
Build succeeded: |
Run with: